ramsestom
commented
5 years ago EDIT: actually this fix prevent the AutoCompleteTextField to crash but do not fix the underlying bug. It appears that the AutoCompleteTextField do not always show the suggestions popup and the really weird thing is that executing the exact same code multiple times in the simulator sometimes work and sometimes dont... My code use an AutoCompleteTextField with a filter defined like this:
final DefaultListModel<String> options = new DefaultListModel<>();
AutoCompleteTextField gui_markTF = new AutoCompleteTextField(options) {
@Override
protected boolean filter(String text) {
if(text.length() == 0) {
return false;
}
String[] l = getBrands(text);
if(l == null || l.length == 0) {
return false;
}
options.removeAll();
for(String s : l) {
options.addItem(s);
}
return true;
}
};where getBrands(text) is a simple function that always return the same String array for now (I didn't implement the server requesting part yet).
public static String[] getBrands(String text) {
return new String[] {"Ba", "Be", "Bi", "Bo", "Bu", "Machin", "Truc", "Bidule"};
}and when I click on the AutoCompleteTextField, the suggestion popup sometimes shows and sometimes dont (previously to my fix it was sometimes crashing and sometimes not).
So it means that popup.getComponentCount() is sometimes equals to 0 and sometimes not when reaching line 523 of the AutoCompleteTextField code.
That fact that the same code produce different results when run multiple times makes me think that there is some kind of race condition bug in the current AutoCompleteTextField implementation...
shannah
In some edge cases AutoCompleteTextField was crashing and returning an indexoutofbounds exception. Fixed it in my fork by replacing line 523
if(((List)popup.getComponentAt(0)).getModel().getSize() == 0){byif( popup.getComponentCount()==0 || ((List)popup.getComponentAt(0)).getModel().getSize() == 0){(didn't bother to make a PR as it is a simple one line fix)