search

codenameone / CodenameOne

Cross-platform framework for building truly native mobile apps with Java or Kotlin. Write Once Run Anywhere support for iOS, Android, Desktop & Web.
https://www.codenameone.com/
Other
1.72k stars 409 forks source link

Format pom.xml of the Generated Maven project #3807

Closed Eric-Chomba closed 1 month ago

Eric-Chomba commented 5 months ago

A Generated Maven project at https://start.codenameone.com/ has unnecessary line breaks in pom.xml of the project's root directory MyApp/myapp/pom.xml which requires a lot of scrolling when studying the pom.xml. Can the unnecessary line breaks be removed as in common/pom.xml?

cn1.plugin.version in MyApp/myapp/pom.xml is generated as 7.0.86. can it be latest CN1 version number by default also?

HrithikPadavala commented 5 months ago

May I know the latest CN1 version number??

Eric-Chomba commented 5 months ago

May I know the latest CN1 version number??

7.0.150

Latest version is aways release here

https://github.com/codenameone/CodenameOne

HrithikPadavala commented 5 months ago

Thanks, I'll work on it

HrithikPadavala commented 5 months ago

I have made required changes and opened a PR. Could someone please check and let me know.

shai-almog commented 5 months ago

@HrithikPadavala I don't see the PR. Did you submit it? It should appear here: https://github.com/codenameone/CodenameOne/pulls

HrithikPadavala commented 5 months ago

I found the corresponding codebase for https://start.codenameone.com/ at https://github.com/shannah/coderad2-starter-template. You can see my PR here https://github.com/shannah/coderad2-starter-template/pulls

shai-almog commented 5 months ago

@HrithikPadavala that's a template. All the links you provided are dead.

HrithikPadavala commented 5 months ago

Thanks for the clarification @shai-almog . I am unable to find the corresponding pom.xml. Could you please let me know where can I find it.

shai-almog commented 5 months ago

@HrithikPadavala sorry, I didn't realize you're trying to fix this issue. It's probably not an issue you can fix. I'm not sure if that code is even public. Notice that it isn't marked as a "Good first issue" and is already assigned to Steve. You wouldn't find the pom.xml since that file is generated automatically by the start server.

HrithikPadavala commented 5 months ago

Okay. I'll try working on another issue.

shannah commented 1 month ago

Been banging my head on this one. Was not able to reproduce locally, but am able to reproduce on server. Finally found what it probably is. This bug: https://issues.apache.org/jira/browse/ARCHETYPE-584

shannah commented 1 month ago

Fixed this by updating server to use newer version of maven. Also required disabling "grape" which was required in maven 3.6.0 in the post archetype processor, but caused problems in 3.6.3+.

TLDR: If you go to start.codenameone.com and generate a project now, the pom.xml files should look neater.

Eric-Chomba commented 1 month ago

Yes, the are neater now.