search

codenameone / CodenameOne

Cross-platform framework for building truly native mobile apps with Java or Kotlin. Write Once Run Anywhere support for iOS, Android, Desktop & Web.
https://www.codenameone.com/
Other
1.72k stars 409 forks source link

Update Form.java #3808

Closed ImmediandoSrl closed 5 months ago

ImmediandoSrl commented 5 months ago

update method called on InPlaceEditView for adding support to KEY TAB phyisical keyboard

shai-almog commented 5 months ago

This pull request is problematic. It exposes internal implementation details and as far as I can tell it has no real purpose. It's used within https://github.com/codenameone/CodenameOne/pull/3809 to implement cyclic focus. That means we can't build https://github.com/codenameone/CodenameOne/pull/3809 until this is merged which I don't think we should.

Cyclic focus is already enabled in the code by default, if that isn't working then the problem is in the application logic. Notice that the code for traversing text components uses the getTabIterator method internally to find the next appropriate component. That method is public and as far as I can tell should be cyclic.

ImmediandoSrl commented 5 months ago

ok my goal was turn to first textfield when tab on last one. found the property setNextFocusRight to solve the problem

shai-almog commented 5 months ago

Cyclic is just that. The focus moves in a cycle. Closing this PR and moving the discussion to the other PR.