codenamesen / jamming

http://jammmIt.surge.sh
0 stars 0 forks source link

Summary #2

Open farishkash opened 6 years ago

farishkash commented 6 years ago

Overall met expectations.

Project is working great. I didn't see any major errors or red flags. My only concern is more presentational, and this is 100 percent opinionated.

Also this is situational, I don't know if you are planning to build a portfolio for reviews.

If you are freelancing then it is your choice.

Either way great job on this project.

I am leaving you with one more example by reformatting your Playlist.js below.

import React, { Component } from "react";
import TrackList from "../TrackList/TrackList";
import "./Playlist.css";

class Playlist extends Component {
  constructor(props) {
    super(props);

    this.handleNameChange = this.handleNameChange.bind(this);
  }
  handleNameChange(e) {
    this.props.onNameChange(e.target.value);
  }
  render() {
    return (
      <div className="Playlist">
        <input
          value={this.props.playListName}
          onChange={this.handleNameChange}
        />
        <TrackList
          tracks={this.props.playlistTracks}
          onRemove={this.props.onRemove}
          isRemoval={true}
        />
        <a className="Playlist-save" onClick={this.props.onSave}>
          SAVE TO SPOTIFY
        </a>
      </div>
    );
  }
}

export default Playlist;
codenamesen commented 6 years ago

Thanks once again I will remember this.