search

codenco-dev / nova-grid-system

Nova grid system for Laravel Nova
80 stars 33 forks source link

the size has no effect on Heading field. #2

Closed issour closed 4 years ago

issour commented 4 years ago

Many thx

domthomas-dev commented 4 years ago

Hi @issour Can you tell me what are Heading Fields for you ? With an example ?

Thanks you

issour commented 4 years ago

Hi @thomasdominic it's like : Heading::make('<p class="text-danger">(*) all fields are required.</p>') Many thx

domthomas-dev commented 4 years ago

In your opinion, what will it do ? A new line ? IMO, it must be "break the flow" It is used to display a banner across your forms and can function as a separator for long lists of fields

issour commented 4 years ago

Hi, Heading is always w-full. But for more flexibility I think can behave like any other field. Thanks you !

Ragash commented 4 years ago

+1 that's very much needed, it will help operating with third party fields without breaking it all (ex. translation fields)

Edit: the problem right now is Heading is not getting wrapped, so it will be crunched in any empty space without respecting the flow.

if you expect something like: [ Heading ] [c][c][c][c][c]

you will get [H][c][c][c][c] [c]

domthomas-dev commented 4 years ago

@Ragash @issour Give me your feedback after trying this.

Thanks

issour commented 4 years ago

@thomasdominic Yesss !! Thanks you very much !! Grand Merci "j'ai vu tes commentaires sur la config en français :) "

Ragash commented 4 years ago

That's perfect! thank you very much!