Breaking layout when using eminiarts/nova-tabs package

[stufarquhar]

This simply does not work when using eminiarts/nova-tabs in detail view. It does however work without the use of tabs thou.

see image.

[vbezruchkin]

Hi,

I have the same problem. Do you expect any fix for this?

Thanks

[domthomas-dev]

@stufarquhar @vbezruchkin Can you check if this release fix your problem ?

https://github.com/codenco-dev/nova-grid-system/releases/tag/1.0.1

I don't know if the problem wasn't with breadcrumb for example.

Thanks for your feedback

[vbezruchkin]

Hi,

Thanks for the fix. Worked fine for me.

Cheers

[domthomas-dev]

@stufarquhar Have you got a feedback ?

[happyDemon]

@thomasdominic I still have an issue here, basically all fields are shown in 1 row when in tab-view, if I disable tabs there's no problem

I threw together a fix and sent a PR to nova-tabs, for the people interested: https://github.com/eminiarts/nova-tabs/pull/97 flex-wrap needed to be added to the fields container on their end

[domthomas-dev]

@happyDemon Can you post a new issue on this repo and give me an example of resource ? I will try to look at this

[happyDemon]

@thomasdominic the main difference with @vbezruchkin is that I used the TabsOnEdit trait on my resource (his screenshot just shows the standard nova form-layout).

The issue is that nova-tabs uses a custom component based on PanelItem and the container element didn't have flex-wrap, which is why all fields were rendered on 1 line.

I sent a PR to nova-tabs, in the meantime I tagged my repo so I could use it in my own projects in the meantime, @eminiarts doesn't seem to be very responsive when I look at all the open PRs.

[domthomas-dev]

Okay :) I hope my package is cool for you :)

[happyDemon]

@thomasdominic this is a killer package :D it's so weird nova doesn't support this out of the box

[domthomas-dev]

@happyDemon hey thanks, don't hesitate to talk about it then :)