codengine / SOTFEdit

A Sons of The Forest Savegame Editor
MIT License
104 stars 6 forks source link

Items not marked as collected on interactive map #31

Closed FBroy closed 5 months ago

FBroy commented 5 months ago

Some items are marked as not collected (red) on the interactive map, even though they are collected in-game. (even after saving and reloading the save in SOTFEdit)

A few items which I can already confirm are affected, are:

There may be more, but these are the ones I can see at first glance. If you need any more information, please let me know.

codengine commented 5 months ago

Could you attach one of the affected savegames so that I can have a look?

FBroy commented 5 months ago

1606965940.zip

This is my most recent save I have. This is a multiplayer save, in case this matters.

Small example: I have the rebreather and collected everything in cave C (the shovel cave), but yet the rebreather is shown in red and the laptop and Flashlight attachment are still shown on the map when selecting to show only uncollected items. image

codengine commented 5 months ago

I found the issue. Items that are currently equipped technically don't appear as "in inventory", so I'm going to have to find a workaround for that. Thanks for the report, I will call back when it is fixed!

codengine commented 5 months ago

Fixed in this release: https://github.com/codengine/SOTFEdit/releases/tag/v0.12.3

FBroy commented 5 months ago

Thanks for the quick patch! I'm currently testing everything and there still seem to be some edge cases.

The rest is working as expected from the patch.

codengine commented 5 months ago

Dang... I was too quick and it was late :P Gonna have a second look.

codengine commented 5 months ago

Please have a look at this build. It should resolve the issue with equipped cloths and weapon mods. SOTFEdit-f5a98877.zip

FBroy commented 5 months ago

After a quick initial test, the clothing and weapon attachments part seems to be fixed. However, now the clothing worn by Kelvin and Virginia is shown on the map as not collected. (Priest outfit for Kelvin and Camouflage outfit for Virginia in this save)

Also, the laptop part still persists. Not sure if you cannot change that at all, since you technically do not "take" the laptop, but just gain the information on it. I could open up another issue for this?

codengine commented 5 months ago

After a quick initial test, the clothing and weapon attachments part seems to be fixed. However, now the clothing worn by Kelvin and Virginia is shown on the map as not collected. (Priest outfit for Kelvin and Camouflage outfit for Virginia in this save)

Also, the laptop part still persists. Not sure if you cannot change that at all, since you technically do not "take" the laptop, but just gain the information on it. I could open up another issue for this?

The laptop is a World Object State I think which is listed here: grafik

But I have no Savegame where every Laptop has been collected, so its kind of hard to research it.

For the outfit, "technically" you don't have it in your inventory. Also it is less of a outfit than more a "flag" for the followers - they do not really own the items. I'd leave it as it is for the follower items.

FBroy commented 5 months ago

Then that solves everything related to this issue! Thanks for taking care of it!