search

codeniko / JsonPathKt

A lighter and more efficient implementation of JsonPath in Kotlin
BSD 3-Clause "New" or "Revised" License
62 stars 7 forks source link

Have you considered using kotlinx.serialization? #7

Open jschneidereit opened 4 years ago

jschneidereit commented 4 years ago

If you're not opposed, would you accept a pull request?

(https://github.com/Kotlin/kotlinx.serialization/blob/master/docs/json.md#subtypes-of-json-elements)

codeniko commented 4 years ago

Hi! Interesting, I'm not familiar with that one and am open to a pull request. It will definitely be nice to have a full kotlin solution rather than my using of Jackson internally.

Feel free to go at it, I have plenty of unit tests to ensure outputs are what they are expected to be. Hopefully the performance will be better or atleast on par than with Jackson; There is a benchmark test in the repo we can use to verify that and I can offer some help too

jschneidereit commented 4 years ago

Cool! I'm trying to go full kotlin in my project as well and get rid of json-path and json-path-assert (wanna take a stab? 😛). As I understand it kotlinx.serialization is certainly faster than Jackson in terms of unmarshalling, but I'm not sure about using dictionaries etc.

I'll take a look tomorrow and see how much work it might be 👍

jschneidereit commented 4 years ago

Also, are you opposed to a more recent version of gradle?

codeniko commented 4 years ago

Not opposed, go for it. I would take a stab at your project but I'm currently busy with some other side projects haha

jschneidereit commented 4 years ago

Cool. I got started on the new gradle version (kinda painful with jacoco migrations and such) and once I'm done with that I'll go for the kotlinx.serialization bit! 👍

erawhctim commented 2 years ago

@jschneidereit did you ever make any progress porting this to kotlinx.serialization?