search

codenoble / cache-crispies

Speedy Rails JSON serialization with built-in caching
MIT License
156 stars 16 forks source link

Bump Rails version to 6.1 #34

Closed floriandejonckheere closed 3 years ago

floriandejonckheere commented 3 years ago

Bump required Rails version to < 6.2.

I also installed and disabled RuboCop, since Code Climate was giving me a hard time with offenses on existing code.

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit f835c580 and detected 0 issues on this pull request.

View more on Code Climate.

floriandejonckheere commented 3 years ago

@adamcrown Sorry for the email spam, I had some trouble with Code Climate.

For now, I installed RuboCop and put all offenses on the ignore list. Perhaps we should look into cleaning up the code so we can use RuboCop on a regular basis for this gem?

adamcrown commented 3 years ago

Thanks @floriandejonckheere but https://github.com/codenoble/cache-crispies/pull/33 came in first, so I merged it. And I think I'll just have to go through and address some of those codeclimate issues separately.

floriandejonckheere commented 3 years ago

Thanks @adamcrown! My fault for not checking the open PRs first.