search

codenotary / immudb

immudb - immutable database based on zero trust, SQL/Key-Value/Document model, tamperproof, data change history
https://immudb.io
Other
8.54k stars 341 forks source link

chore: set repository_owner dynamically in the push workflow. #1947

Closed seuros closed 4 months ago

seuros commented 4 months ago

The GitHub workflow push.yml was updated to use the repository owner's Docker images instead of fixed ones.

This change allows for more flexibility and control when using Docker images, and ensures that the correct images are used based on the repository owner.

This allow forked repos to not push in the immudb organization by default

SimoneLazzaris commented 4 months ago

That is working, but it is a (fortunate) coincidence that in our case the repository owner (codenotary) is the same as the docker hub user (again, codenotary).

Some other user may be in need of a different string. So maybe it's best to use a github variable.

seuros commented 4 months ago

@SimoneLazzaris , i was going to use secrets.REGISTRY_USER, but i endup using an environment variable.

btw REGISTRY_USER should be a variable not a secret.