search

codenotary / immudb

immudb - immutable database based on zero trust, SQL/Key-Value/Document model, tamperproof, data change history
https://immudb.io
Other
8.54k stars 341 forks source link

immudb service install rely on "addgroup" which is only present in debian-based distros #507

Closed SimoneLazzaris closed 3 years ago

SimoneLazzaris commented 3 years ago

What happened

I've run "immudb service install" on a fresh CentOS, but the installation fails, with the error: Error: exec: "addgroup": executable file not found in $PATH

What you expected to happen The command should have created a system service for immudb. It is evident that the group creation is relying on "addgroup" which is only present in debian-based distros.

How to reproduce it (as minimally and precisely as possible) It's easy, just launch immudb service install on a centos or red hat box.

Environment

immudb 0.8.0
Commit  : 628151a2ef58c86400350da85dec3edf3a4f03f8
Built by: cleaversdev@gmail.com
Built at: Tue, 15 Sep 2020 15:03:52 CEST

Additional info (any other context about the problem) The fix should be trivial, just switch from addgroup to groupadd, which is present in all distros

SimoneLazzaris commented 3 years ago

Fixed by commit 1cdab5805cf79d73fbc9219129fee58dff2ba1f9