codenotary / immugw

Apache License 2.0
23 stars 4 forks source link

Healthcheck endpoint /serverinfo requires a non-providable parameter databaseName #32

Closed NikitaSmall closed 1 year ago

NikitaSmall commented 1 year ago

What happened When the endpoint is requested, it always returns {"code":3,"message":"missing parameter databaseName"} error, as internally the endpoint tries to build a client based on a specific database connection.

What you expected to happen We expect the endpoint to provide a status report for running the Immugw service without authentication. Minimal health check info would be enough, e.g. {"code":0,"status":"healthy"}, including 200 HTTP status code.

How to reproduce it (as minimally and precisely as possible) Spin up the docker container for ImmuDB and Immugw, expose 3323 port, run curl http://localhost:3323/serverinfo.

jeroiraz commented 1 year ago

Hi @NikitaSmall, I think the fix on branch fix_serverinfo solves the issue, it would be great if you can validate it

NikitaSmall commented 1 year ago

@jeroiraz, you are right! I checked that yesterday, works like a charm!

Thank you for a fast update!