search

codenvy-legacy / sdk

This repository is deprecated.
http://eclipse.org/che
43 stars 22 forks source link

Increasing Che portability #59

Closed lextiz closed 9 years ago

lextiz commented 9 years ago

1) Set slf4j-log4j12 as provided, because it is supplied by tomcat. This jar is copied to tomcat libs directory by maven as described pom.xml of assembly-sdk 2) Added configuration for JarScanner component of tomcat to context.xml, for newer versions of tomcat (>=7.0.56) to be able to find DynaModules 3) Did sanity test, this does not seem to break any existing functionality

Thanks.

codenvy-ci commented 9 years ago

Can one of the admins verify this patch?

skabashnyuk commented 9 years ago

In this PR mixed two changes. You should decouple 1 and 2. We didn't use log4j as slf4 backend. Logback is prefered. Backend should not be add in war.

lextiz commented 9 years ago

I will split the changes. De facto slf4j-log4j12 dependency is present in pom.xml, and it is packaged to WAR, Tomcat issues warning for this. By adding "provided" scope for this dependency, I meant to eliminate the warning. Anyway if this dependency is not used it would be good to remove it, but this is different issue.