codeoverflow-org / nodecg-io

A NodeCG-bundle which implements Social Media API's in the NodeCG framework
https://nodecg.io
MIT License
108 stars 26 forks source link

Stop all service clients when NodeCG is stopping #21

Closed hlxid closed 4 years ago

hlxid commented 4 years ago

Description

Currently service clients just get killed when stopping NodeCG. Instead all clients should be gracefully stopped when NodeCG is stopping by using the stopClient function of the corresponding services.

TimTechDev commented 4 years ago

@noeppi-noeppi Is this issue definitely fixed? - If so could you remove it from the Streamdeck-sample docs? Thanks

https://github.com/codeoverflow-org/nodecg-io-docs/blob/debb00cb5296fb8e4ed8c5340faead4172c75117/docs/samples/streamdeck.md#L34