codeoverflow-org / nodecg-io

A NodeCG-bundle which implements Social Media API's in the NodeCG framework
https://nodecg.io
MIT License
108 stars 26 forks source link

Nodecg-io Dashboard can't Login When in an OBS Custom Dock #311

Closed devJimmyboy closed 2 years ago

devJimmyboy commented 2 years ago

Description

Fullbleed panel for NodeCG-io doesn't allow logging in to the config when located in an OBS Browser Dock.

From the get-go, I'd say it has to do with functionality with OBS's Chromium Version. I'd make sure to build with a browserlist of chrome >= 74 to account for OBS's older browser support. (although you could already be doing this, as I haven't checked nor know how to)

How to reproduce

Error Log

``` Uncaught (in promise) ReferenceError: monaco is not defined at showInMonaco (main.bundle.js:374) at onInstanceSelectChange (main.bundle.js:185) at selectServiceInstance (main.bundle.js:338) at renderInstances (main.bundle.js:319) at Config. (main.bundle.js:139) at Config.emit (main.bundle.js:8067) at updateDecryptedData (main.bundle.js:561) at main.bundle.js:519 at Generator.next () at fulfilled (main.bundle.js:960) ```
hlxid commented 2 years ago

I've succesfully reproduced this bug with OBS Studio 27.1.3 (the currently latest version) and fixed it with #312. You can either use the current development version for this fix or wait till (approximately) friday, as I'll release nodecg-io version 0.2.0 soon.

devJimmyboy commented 2 years ago

Awesome! Thanks a lot! Can't wait for 0.2.0!