Sprint 3: progress animation (play with the size)

[leoliudeprecated]

http://i.imgur.com/SqWAA4l.png find a better progress animation to replace this? or don't use progress animation. use transition animation instead.

[Marusya82]

I like the current progress animation and already spent time on working on that, don't understand the need to change that?

[leoliudeprecated]

can we discuss this and make the decision by three of us? i didn't see your pull request

On Mon, Sep 5, 2016 at 9:02 AM, Marina Tanasyuk notifications@github.com wrote:

I like the current progress animation and already spent time on working on that, don't understand the need to change that?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/codepath-project-stories/timeline/issues/80#issuecomment-244777861, or mute the thread https://github.com/notifications/unsubscribe-auth/ACgtw3UVUBv3_hI6Gex4NpISh_l3jTigks5qnD0BgaJpZM4J1L7R .

[Marusya82]

what pull request are you talking about?

[leoliudeprecated]

your pull request when making this change

On Mon, Sep 5, 2016 at 9:11 AM, Marina Tanasyuk notifications@github.com wrote:

what pull request are you talking about?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/codepath-project-stories/timeline/issues/80#issuecomment-244779426, or mute the thread https://github.com/notifications/unsubscribe-auth/ACgtw5yDDYbZZM0XKCJ32R_uSaySHSKCks5qnD8_gaJpZM4J1L7R .

[Marusya82]

it was ages ago Ching-yao, you are kinda late on this. I asked everyone on slack and we agreed with Dianne on the progress bar, if you think this is necessary to change this now we can talk about again it when Dianne comes online.

[leoliudeprecated]

i just want to bring this up, so we can discuss this again.

On Mon, Sep 5, 2016 at 9:14 AM, Marina Tanasyuk notifications@github.com wrote:

it was ages ago Ching-yao, you are kinda late on this. I asked everyone on slack and we agreed with Dianne on the progress bar, if you think this is necessary to change this now we can talk about it when Dianne comes online.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/codepath-project-stories/timeline/issues/80#issuecomment-244779915, or mute the thread https://github.com/notifications/unsubscribe-auth/ACgtw20rNgkXDzlXXcOsb3qP8f4JHbhfks5qnD_kgaJpZM4J1L7R .

[leoliudeprecated]

make it a little smaller? i don't know. https://github.com/81813780/AVLoadingIndicatorView

[Marusya82]

You can read the feed about it here on slack https://codepathuniversity.slack.com/archives/G20HNMEUQ/p1472528890000011

Sure, we can make it smaller, like the medium size? At the moment it is set to large. Or maybe change of color to primary will make you happy?

[leoliudeprecated]

i remember this. i just feel maybe we can discuss this, and polish it a bit. if you don't want to, that's fine.

[Marusya82]

This was in my previous comment "Sure, we can make it smaller, like the medium size? At the moment it is set to large. Or maybe change of color to primary will make you happy?", doesn't it look like I am open to polish? I just don't feel comfortable with the idea of a deeper change, like replacing it with a different progress bar and disregarding other people work and doing all of it on the day when we are doing code freeze, we need to polish small things and look for bugs. The deeper changes to the flow and UI we can discuss after the internal demo.

[Marusya82]

Changed the color, will close for now: https://codepathuniversity.slack.com/archives/G20HNMEUQ/p1473100465000041