search

codepicky / skype-patch

8 stars 3 forks source link

Invalid filename #1

Open ownmaster opened 4 years ago

ownmaster commented 4 years ago

I can't successfully clone the project to a Windows 10 machine: (Invalid argument)eate file Icon (Invalid argument)eate file stubs/Icon fatal: unable to checkout working tree warning: Clone succeeded, but checkout failed. Seems like the problem is in "Icon" file name, here is what git status reports: D "Icon\r" D "stubs/Icon\r" On github URL to one of the files looks like this: https://github.com/codepicky/skype-patch/blob/master/Icon%0D

dsultanr commented 4 years ago

@ownmaster, any succes on patching Windows skype?

@degecko is it possible to get this working on Windows?

I'm getting theese errors:

D:\Downloads\skype-patch-master>node patch.js "c:\Program Files (x86)\Microsoft\Skype for Desktop\resources"
Creating a backup of app.asar because none exists.
(node:20696) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open 'c:\Program Files (x86)\Microsoft\Skype for Desktop\resources/app/js/app.js'
    at Object.openSync (fs.js:458:3)
    at Object.readFileSync (fs.js:360:35)
    at D:\Downloads\skype-patch-master\patch.js:41:31
(node:20696) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:20696) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

any thoughts?

degecko commented 4 years ago

@ownmaster Please try again.

@dsultanr The problem seems to be that Windows uses backward slashes as path separators. I've added a possible fix, but it needs to be tested. Please let me know if it works now.

dsultanr commented 4 years ago

thanks @degecko

I can't see your slahes fix but I think the slashes are not a single problem

actually there is no js/app.js in resources folder

here is what my tree command returning:

|   app.asar
|   app.asar.bak
|   app.asar.new
|   
\---app.asar.unpacked
    \---node_modules
        +---electron-ssid
        |   \---build
        |       \---Release
        |               electron-ssid.node
        |               
        +---electron-utility
        |   \---build
        |       \---Release
        |               electron_utility.node
        |               
        +---keytar
        |   \---build
        |       \---Release
        |               keytar.node
        |               
        +---msft-wam
        |   \---build
        |       \---Release
        |               wam.node
        |               
        +---slimcore
        |   \---bin
        |           onnxruntime.dll
        |           platform.node
        |           Processing.NDI.Lib.x86.dll
        |           RtmCodecs.dll
        |           RtmControl.dll
        |           RtmMediaManager.dll
        |           RtmPal.dll
        |           RTMPLTFM.dll
        |           sharing-indicator.node
        |           skypert.dll
        |           slimcore.node
        |           ssScreenVVS2.dll
        |           trouter-client.node
        |           TxNdi.dll
        |           
        \---uwp-credentials-fetcher
            \---build
                \---Release
                        uwp_credentials_fetcher.node