Modernizing and cleanup

[simonc]

Would you be open to pull requests to "modernize" the gem a bit ?

By modernizing, I mean:

• Use gemspec in Gemfile to reduce duplication
• Clean up the the gemspec, remove Jeweler dependency and simplify it (the bundler way)
• Add Travis-CI, CodeClimate, Gemnasium and CoverAll
• Clean up the specs to make it more "rspec-way"

I'd also clean up the Wiki to refresh it a bit concerning Rails and Ruby versions.

I'd really love to see simple-navigation keep up with the community. It's an awesome project and I can give some time to help :)

[andi]

Hi Simon,

all help will be highly appreciated :-)

Thanks Andi

On Fri, Feb 14, 2014 at 3:35 PM, Simon Courtois notifications@github.comwrote:

Would you bee open to pull requests to "modernize" the gem a bit ?

By modernizing, I mean:

• Use gemspec in Gemfile to reduce duplication
• Clean up the the gemspec, remove Jeweler dependency and simplify it (the bundler way)
• Add Travis-CI, CodeClimate, Gemnasium and CoverAll
• Clean up the specs to make it more "rspec-way"

I'd also clean up the Wiki to refresh it a bit concerning Rails and Ruby versions.

I'd really love to see simple-navigation keep up with the community. It's an awesome project and I can give some time to help :)

— Reply to this email directly or view it on GitHubhttps://github.com/andi/simple-navigation/issues/145 .

[simonc]

Ok, here is the first step, I cleaned up all all all the specs to use the new expect syntax and give more complete/clear descriptions. This PR also drops Jeweler and cleans up the way rspec is called.

I know it's a lot to review but basically the specs are the same ;)

[simonc]

Oh and I also added guard-rspec.

[andi]

Great, thanks! More to come? I will do a new release soon :-)

[andi]

It would be great if you could remove jeweler and fix gemspec for https://github.com/andi/sinatra-simple-navigation as well, could you do that?

[simonc]

Yes more to come, that was just to get started ;) Ok I'll take a look to it.

[andi]

:-) Ok thanks! I will release a new version today anyways. The next one in about 2-3 weeks. I guess that is not a bad timing...

Cheers Andi

On Tue, Feb 25, 2014 at 2:15 PM, Simon Courtois notifications@github.comwrote:

Yes more to come, that was just to get started ;) Ok I'll take a look to it.

— Reply to this email directly or view it on GitHubhttps://github.com/codeplant/simple-navigation/pull/145#issuecomment-36005731 .

[simonc]

I think it's ok. I am currently rebasing several branches:

• Full code cleaning
• Adding Travis-CI config (could you add the project on Travis ? :smile:)
• Adding Coveralls
• Cleaning up the README

[andi]

• Adding Travis-CI config (could you add the project on Travis ? [image: :smile:])

done :-)

• Cleaning up the README

I just transferred the repo and hence did some changes to README. but you probably already noticed :-)

— Reply to this email directly or view it on GitHubhttps://github.com/codeplant/simple-navigation/pull/145#issuecomment-36009197 .

[simonc]

Yes I did so I took it into account in the next PR :)

[andi]

Thanks for all your help so far!

[simonc]

My pleasure ;)