Removing future rspec deprecations

codeplant / simple-navigation

A ruby gem for creating navigations (with multiple levels) for your Rails, Sinatra or Padrino applications. Render your navigation as html list, link list or breadcrumbs.

http://simple-navigation-demo.codeplant.ch/

MIT License

885 stars 136 forks source link

Removing future rspec deprecations #152

Closed simonc closed 10 years ago

simonc commented 10 years ago

This commit removes deprecations planned in the next RSpec release:

be_false is changed to be_falsey
be_true is changed to be_truthy
have(n).items is changed to expect(x.size).to eq(n)

coveralls commented 10 years ago

Coverage remained the same when pulling bd6a29bcc9fe404b6697582fc9e6f349f4bc94d0 on simonc:remove-rspec-deprecations into 21c8a27d7573f6ed3682ba4560075d8f321fd3e6 on codeplant:master.

codeplant commented 10 years ago

specs are failing for this one (on travis)

simonc commented 10 years ago

Weird, "it works on my machine" :/ RSpec 3 will be out soon, this PR can stick around until it's released if that's ok with you :)

andi commented 10 years ago

sure :-)

On Thu, Feb 27, 2014 at 11:22 AM, Simon Courtois notifications@github.comwrote:

Weird, "it works on my machine" :/ RSpec 3 will be out soon, this PR can stick around until it's released if that's ok with you :)

— Reply to this email directly or view it on GitHubhttps://github.com/codeplant/simple-navigation/pull/152#issuecomment-36228271 .