search

codeplant / simple-navigation

A ruby gem for creating navigations (with multiple levels) for your Rails, Sinatra or Padrino applications. Render your navigation as html list, link list or breadcrumbs.
http://simple-navigation-demo.codeplant.ch/
MIT License
885 stars 136 forks source link

Dropping Rails < 3.2 support #156

Closed simonc closed 10 years ago

simonc commented 10 years ago

The Rails maintenance policy indicates that rails < 3.2 will not be supported after Rails 4 release (see: http://weblog.rubyonrails.org/2013/2/24/maintenance-policy-for-ruby-on-rails/).

I think it would be OK to drop Rails < 3.2 too. This way it would be possible to enjoy ActiveSupport::Concern and other neat stuff :)

Since it's a backward-compatibility-breaking change, it makes sense to release a major version (which we should have done when dropping Ruby 1.8, now that I think of it).

What do you think ?

andi commented 10 years ago

yes, that sounds like a plan

andi commented 10 years ago

do you think we should re-introduce 1.8 compatibility until we release version 4.x?

simonc commented 10 years ago

No it's done, but we'll try to respect semantic versioning for next releases :)

simonc commented 10 years ago

Since ControllerMethods has been moved away and is considered deprecated since 3.0.0. Would it be OK to remove it in the next major release?

andi commented 10 years ago

Yes, we should get rid of that module.

On Thu, Mar 6, 2014 at 11:25 AM, Simon Courtois notifications@github.comwrote:

Since ControllerMethods has been moved away and is considered deprecated since 3.0.0. Would it be OK to remove it in the next major release?

— Reply to this email directly or view it on GitHubhttps://github.com/codeplant/simple-navigation/issues/156#issuecomment-36842314 .

simonc commented 10 years ago

Awesome! :+1:

simonc commented 10 years ago

Tests passing and all working well in the test app I have :)