Rails 4.2 compatibility fixes.

codeplant / simple-navigation

A ruby gem for creating navigations (with multiple levels) for your Rails, Sinatra or Padrino applications. Render your navigation as html list, link list or breadcrumbs.

http://simple-navigation-demo.codeplant.ch/

MIT License

885 stars 136 forks source link

Rails 4.2 compatibility fixes. #174

Closed voxik closed 9 years ago

voxik commented 9 years ago

This contains some fixes needed for Rails 4.2 compatibility.

However, please note that there are still some remaining issues with "SimpleNavigation::Adapters::Rails.register" tests. Also, I tested this patch just against Rails 4.2 and moreover, I tested this changes just with S-N 3.14.0 and later forward ported them, so there is probably missing something more. But I hope you can use this PR for inspiration at least ;)

andi commented 9 years ago

Thanks, will take a look.

simonc commented 9 years ago

Hi @voxik and thanks. I've been working on integration testing and I waiting just now for the branch to green-light on Travis. It tests SN against Ruby 2.0, 2.1 and 2.2 in combination with Rails 3.2, 4.1 and 4.2.

Once finished I'll merge and close this PR, thank you for it :)