codeplant / simple-navigation

A ruby gem for creating navigations (with multiple levels) for your Rails, Sinatra or Padrino applications. Render your navigation as html list, link list or breadcrumbs.
http://simple-navigation-demo.codeplant.ch/
MIT License
885 stars 136 forks source link

add options rendering to json renderer #213

Closed mikekytyzov closed 2 years ago

mikekytyzov commented 6 years ago

idk why from renderer to renderer item params so differ

if we have some navigation with params, it should return all of the defined options regardless of renderer, isnt it ?

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 99.488% when pulling 4245823574708e531e87bef1ba9e154c83ff41fb on activeby:extend_json_renderer into 3df3a88fd65645eba1d9fd8dcfd59804e9f6232c on codeplant:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.616% when pulling 388ef42aed93bd294613953f67bcf62e10283ead on activeby:extend_json_renderer into 3df3a88fd65645eba1d9fd8dcfd59804e9f6232c on codeplant:master.

andi commented 6 years ago

thanks, could you just add a test case for this so that the coverage is 100 again? thanks!

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.001%) to 99.617% when pulling 3238d59caad235e054045f42fe17430b0c8a5035 on activeby:extend_json_renderer into 3df3a88fd65645eba1d9fd8dcfd59804e9f6232c on codeplant:master.

mikekytyzov commented 6 years ago

@andi done

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.001%) to 99.617% when pulling 3238d59caad235e054045f42fe17430b0c8a5035 on activeby:extend_json_renderer into 3df3a88fd65645eba1d9fd8dcfd59804e9f6232c on codeplant:master.

mikekytyzov commented 6 years ago

@andi btw, its good to add to renderer others options, like html, link_html etc..

AlejandroMI commented 2 years ago

Is this repo still maintained? I have the same problem as @mikekytyzov, can we get this merged @andi ?

mikekytyzov commented 2 years ago

@AlejandroMI i just made a fork, pr 5 years ago xd

AlejandroMI commented 2 years ago

@AlejandroMI i just made a fork, pr 5 years ago xd

I was thinking about that, but it would be great to see this repo coming back to life 😞

AlejandroMI commented 2 years ago

Thank you @andi 🙌