std::string::replace takes pos and count parameters, not start and end. This was not previously covered by testing because either the format specifier appeared at the start (meaning count and end are the same), or the format specifier appeared at the end (meaning there are no characters after the format specifier to cut off).
Description of change
Add a test that puts the format specifier in the middle.
Anything else we should know?
If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.
Overview
Fix printf of nan.
Reason for change
std::string::replace takes pos and count parameters, not start and end. This was not previously covered by testing because either the format specifier appeared at the start (meaning count and end are the same), or the format specifier appeared at the end (meaning there are no characters after the format specifier to cut off).
Description of change
Add a test that puts the format specifier in the middle.
Anything else we should know?
If there's any other relevant information we should know that may help us in understanding and verifying your patch, please include it here.
Checklist