codeplaysoftware / oneapi-construction-kit

Other
68 stars 30 forks source link

[MSVC] Fix debug builds. #495

Closed hvdijk closed 2 months ago

hvdijk commented 2 months ago

Overview

[MSVC] Fix debug builds.

Reason for change

We build Abacus in debug builds with /RTCc to flag out of range conversions, but this is a leftover from when Abacus was its own project. In oneAPI Construction Kit, it does not make sense and does not work, as the infrastructure to report such conversions is not available. It was also completely untested as it was only enabled in Debug builds, which we never ran.

Description of change

Remove /RTCc.

Anything else we should know?

If there's any other relevant information we should know that may help us in understanding and verifying your patch, please include it here.

Checklist