Set -enable-global-offset=false

codeplaysoftware / portBLAS

An implementation of BLAS using the SYCL open standard.

Apache License 2.0

250 stars 48 forks source link

Set -enable-global-offset=false #516

Closed pgorlani closed 4 months ago

pgorlani commented 4 months ago

This patch disables the compilation of unused/deprecated global-offset kernels.

Rbiessy commented 4 months ago

Why does this all have to duplicated?

I think we don't have much choice because when building the library we want to use the PRIVATE visibility to only use the flag for portBLAS, in header-only mode this needs to the INTERFACE visibility to add this flag to anything using portBLAS. We could consider having a helper function but I'm not sure it would help that much.