Update rotmg interface to handle issue in OpenCL CPU support

codeplaysoftware / portBLAS

An implementation of BLAS using the SYCL open standard.

Apache License 2.0

250 stars 48 forks source link

Update rotmg interface to handle issue in OpenCL CPU support #532

Closed s-Nick closed 3 weeks ago

s-Nick commented 1 month ago

To offer proper oneMKL support rotmg operator must support the possibility to have y1 argument passed as scalar value. This PR enables this possibility by adding a check on its type and handling both cases: pointer/buffer or scalar. Moreover, due to a bug in OpenCL the copy for DEFAULT target, that it generally used on CPUs, must be explicitly synchronized if using USM.

pgorlani commented 1 month ago

I think that src/interface/blas1/rotmg.cpp.in needs to be updated in order to consider the new rotmg interface. Probably, the unit test could be updated as well.

s-Nick commented 3 weeks ago

@pgorlani I added the new interface and modify the tests in 39016ea