Closed senwang86 closed 1 year ago
Thanks, this works well to fix #420.
Do you plan to merge selectedPods
and cursorNode
in the next PR? I think jumping around should change the selected nodes.
Thanks, this works well to fix #420.
Do you plan to merge
selectedPods
andcursorNode
in the next PR? I think jumping around should change the selected nodes.
Yes, I plan to have a following PR. I think it's cleaner to use different states for "single-selection" and "multi-selection"; and "multi-selection" could be achieved through keyboard shortcut, say pressing SHIFT
+ArrowUP|Down|Left|Right
.
An array-based selectedPods
can also handle the "single-click" well (by always taking selectedPods[-1]
), without bringing in a new state variable.
SG, thanks!
Summary
PR #398 introduced CMD mode, and issue #418 and #420 reveal some improvement and bugs.
SHIFT
+ArrowDown
SHIFT
+ArrowUp
useJump()
usesselectedPods
to choose thefrom
node, while in a multi-selection scenario,selectedPods
contains more than 1 node. As a workaround, a new state variablecursorNode
is added for a single node selection.SHIFT
+Enter
will run the podSHIFT
+Enter
will run the scopeTest