Closed senwang86 closed 1 year ago
Nice! A few issues:
Nice! A few issues:
- In Edit mode, we should disable dragging, so that we can move cursor or select text.
- In Edit mode of the Rich pod, I cannot chick to move the cursor or select text. This is related to 1.
Nice catch, 136479f fixed 1 and 2.
- There's a console warning that seems to be a rendering dependency issue.
It says that certain changes in Rich.tsx
breaks different components(RepoImpl
, SyncStatus
, etc) occasionally, but I didn't figure out the reason yet.
Cool. I'll examine the console warning and the Monaco editor's cursor issue.
Fixed a few issues.
Fixed a few issues.
- fix the Monaco cursor & selection using an overlay.
- the console warning is caused by editable=fasle not compatible with YjsExtension
It turns out that editable=false
+selectively load YjsExtension
solution will prevent Yjs from syncing. Now I'm using the same overlay in both code & rich pods. See commit f4d9892 in #440
Summary
Edit
mode.CMD
modeTest