search

codepress / admin-columns-issues

Issues for Admin Columns Pro
https://www.admincolumns.com/
11 stars 0 forks source link

Missing Localization String in Admin Column Edit #1254

Closed fabiangigler closed 5 years ago

fabiangigler commented 5 years ago

The labels "Edit" and "Clone" in the Admin Column Settings are not localized.

Screenshot of the Admin Screen (de_DE) : grafik

The String for "Clone" is also not in transifex: grafik

fabiangigler commented 5 years ago

I just realized there are several String on the same page that are not Localized in the UI and not showing up in Transifex: grafik

In the Tabs on top: "Settings" Next to the Column Selector: "View" On the Bottom of the Columns: "Add Column"

I can supply the german translations as soon as the strings are added in transifex.

DGStefan commented 5 years ago

@fabiangigler Thanks for your input. I will check the plugin for the missing string. Also be aware that our pro version contains the free version that has its own translation file managed on wordpress.org. https://translate.wordpress.org/locale/de/default/wp-plugins/codepress-admin-columns/

DGStefan commented 5 years ago

@fabiangigler I checked and both the strings for 'Edit' and 'Clone' are part of the free version which can be translated on Wordpress.org. And the same goes for all the other string you mention.

fabiangigler commented 5 years ago

Hey @DGStefan thanks for the answer, you are indeed right about that. I just added some german translations.

However the string translations for "Clone" and "Edit" were already existing prior to my added translations. I also checked the plugin files and it seems like the strings are properly passed through the _e() translation function.

BUT I still see a weird mix of German and English in my WordPress Backend: grafik