search

codepress / admin-columns-issues

Issues for Admin Columns Pro
https://www.admincolumns.com/
11 stars 0 forks source link

Improved segments #1327

Closed davidmosterd closed 3 years ago

davidmosterd commented 4 years ago

Right now segments are integrated with search. While that works good, it does not represent how the LS is rendered when the URL is rebuild as it does not take default / other custom filters into account.

davidmosterd commented 4 years ago

Proposal how new segments could work. Supports order, orderby and non AC filters and combines them as url_parameters along with the segment.

davidmosterd commented 4 years ago

@DGStefan please have a look what you think in working, but especially how the JS is written.

davidmosterd commented 4 years ago

What this solution does not (yet) accommodate is array-filters e.g. name[]=1&name[]=2, but this is a start.

tobiasschutter commented 4 years ago

Can we incorporate these issues as well: Sharing Segments: https://github.com/codepress/admin-columns-pro/issues/358 Ordering Segments: https://github.com/codepress/admin-columns-pro/issues/356 Load Last Visited: https://github.com/codepress/admin-columns-pro/issues/361

tobiasschutter commented 4 years ago

@DGStefan Filters that are using a text input (such as the ranged filters) are not being loaded correctly. You can reproduce it by adding the ID column and setting its filter to ranged.

DGStefan commented 3 years ago

Done in 5.3