search

coder / backstage-plugins

Official Coder plugins for the Backstage platform
40 stars 3 forks source link

Coder plugin: integrate new query by workspace param functionality #60

Closed Kira-Pilot closed 6 months ago

Kira-Pilot commented 7 months ago

The Coder API now supports querying workspaces in a deployment by the set value of a coder_parameter. We should simplify our Backstage Coder plugin API layer by integrating this new functionality.

Blocked by https://github.com/coder/coder/issues/10661

Parkreiner commented 6 months ago

The new CoderClient PR is now pending, so I've started on this I think I can have a basic implementation done today, but as I recall, there were some conversations about wanting to improve some of the search logic on Coder core's side. I believe the current implementation only matches exactly, and can't do partial matches. I feel like we mentioned wanting to do partial matches, but I can't remember why

Going to dig through some of the old Slack messages to refresh my memory, and then add some notes here

code-asher commented 6 months ago

One thing that comes to mind is maybe there is a case where a trailing slash is missing, and https://github.com/owner/repo/ in the config does not match https://github.com/owner/repo in a workspace param. Or maybe there is a case where one of them has the /tree/branch syntax and another does not?