Incorrect capture groups during removal

coder / code-marketplace

Open source extension marketplace for VS Code.

GNU Affero General Public License v3.0

217 stars 18 forks source link

Incorrect capture groups during removal #23

Closed podedra92 closed 12 months ago

podedra92 commented 1 year ago

Description

Some packages do not adhere to the expected convention during remove. We are expected to pass publisher.extension-1.0.0 or publisher.extension ParseExtensionID uses regex capture groups to split this string or "id"

May be better placed just to pass in Publisher/extension/version (optional) as seperate args. Or introduce a breaking change like using a different char maybe + to replace - for version identifier

Example Extensions

docker
jupyter-renderers
python

code-asher commented 1 year ago

Thank you for the report!

I think maybe we change this to @, the - was initially done to match VS Code but I think there was a misunderstanding as VS Code actually uses @ (or maybe they ran into the same bug and changed it).