coder / code-server

VS Code in the browser
https://coder.com
MIT License
68.51k stars 5.61k forks source link

node debugging seems not to be working. ever attaches #312

Closed polymerchm closed 5 years ago

polymerchm commented 5 years ago

When running in the shell, with either auto accath or with an attach "task", never seems to connect.

NGTmeaty commented 5 years ago

Can you please fill out the template so we can have more information?

nol166 commented 5 years ago

Hey, @polymerchm can you send us the output of the error message you are getting or the error in the browser developer console?

polymerchm commented 5 years ago

This is the output in the "output" window with "trace" enabled in the attach options:

Error: Cannot find module 'vscode-chrome-debug-core' at Module.r.require (/usr/local/bin/code-server:468:26539) at /home/travis/build/codercom/code-server/packages/server/build/extensions/ms-vscode.node-debug2/out/src/nodeDebug.js/home/travis/build/codercom/code-server/packages/server/build/extensions/ms-vscode.node-debug2/out/src/nodeDebug.js:6:36 at requireFilesystemModule (/usr/local/bin/code-server:468:26288) at Object.exports.requireFork (/usr/local/bin/code-server:468:26641) at v.run (/usr/local/bin/code-server:549:49569) at

nol166 commented 5 years ago

Hey @polymerchm node debugging should be fixed in an upcoming update very soon.

nol166 commented 5 years ago

This will probably be fixed by https://github.com/codercom/code-server/pull/299

jondavidschober commented 5 years ago

I'm having the same issue. I dont have any extensions installed except themes. The output is

 [2019-03-22 18:42:28.087] [exthost] [info] eager extensions activated
 [2019-03-22 18:42:57.484] [exthost] [info] ExtensionService#_doActivateExtension vscode.debug-server-ready {"startup":false,"activationEvent":"onDebugResolve"}
 [2019-03-22 18:42:57.485] [exthost] [info] ExtensionService#loadCommonJSModule /home/travis/build/codercom/code-server/packages/server/build/extensions/debug-server-ready/dist/extension
 [2019-03-22 18:42:57.488] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode.node-debug2 {"startup":false,"activationEvent":"onDebugResolve:node"}
 [2019-03-22 18:42:57.488] [exthost] [info] ExtensionService#loadCommonJSModule /home/travis/build/codercom/code-server/packages/server/build/extensions/ms-vscode.node-debug2/out/src/extension
 [2019-03-22 18:42:57.524] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode.node-debug {"startup":false,"activationEvent":"onDebugResolve:node"}
 [2019-03-22 18:42:57.524] [exthost] [info] ExtensionService#loadCommonJSModule /home/travis/build/codercom/code-server/packages/server/build/extensions/ms-vscode.node-debug/dist/extension.js`

I'm trying to attach to existing node with inspector running. The node process never prints Debugger attached.

I basically get one shot of starting the debugger, it kinda hangs then goes away, then if I try debugging again I get "There is already a debug configuration "Attach" running."

NGTmeaty commented 5 years ago

What version of code-server are you running?

polymerchm commented 5 years ago

-310.Worked when I removed the chrome debugger module.Then tried to add a folder.Now just get black screen after the password screen.

Sent from Xfinity Connect App

------ Original Message ------

From: NGTmeaty To: codercom/code-server Cc:StevenPollack, Mention Sent: March 22, 2019 at 5:10 PM Subject: Re: [codercom/code-server] node debugging seems not to be working. ever attaches (#312)

What version of code-server are you running?

— You are receiving this because you were mentioned. Reply to this email directly,view it on GitHub(https://github.com/codercom/code-server/issues/312#issuecomment-475820983), ormute the thread(https://github.com/notifications/unsubscribe-auth/AGHfku-kmuEiTgghm12jycly3ZNvOc6Mks5vZXD7gaJpZM4cB8zX).

foresthoffman commented 5 years ago

@polymerchm The blank screen after attempting to add a folder will be fixed by #317 in the next release.

jondavidschober commented 5 years ago

@NGTmeaty 1.32.0-310

kylecarbs commented 5 years ago

Fixed with the latest release.

NGTmeaty commented 5 years ago

Thanks Kyle!