Cannot change the display language by installing the language pack extension via cli

hwdef commented 2 years ago

OS/Web Information

Web Browser: firefox/edge
Local OS: windows10
Remote OS: centos7
Remote Architecture: amd64
code-server --version: 4.0.1 735c6da829535969ff7193c79379299e4a1cb9bc

Steps to Reproduce

download language extension (https://marketplace.visualstudio.com/items?itemName=MS-CEINTL.vscode-language-pack-zh-hans)
install it code-server --install-extension MS-CEINTL.vscode-language-pack-zh-hans-1.63.3.vsix
start code-server

Expected

Display language changed to Chinese

Actual

nothing happens, even if I enter Configure Display Language through the command panel, there is no Chinese option

If I install this language extension online, a prompt will pop up in the lower right corner of the browser, asking if I want to change the display language, but there is no prompt after installing the extension offline

Logs

Screenshot

Notes

This issue can be reproduced in VS Code: Yes/No

jsjoeio commented 2 years ago

Hmmm..when I download from OpenVSX, it says not compatible. I think you need to install this version: https://open-vsx.org/extension/MS-CEINTL/vscode-language-pack-zh-hans/1.63.3

However, if I search for it within code-server and click install, it installs and restarts in Chinese.

Video

https://user-images.githubusercontent.com/3806031/149587207-f3275af5-df31-4dcb-9933-ef3d1baa7880.mov

With CLI

I tried again with 1.63.3 and see the same issue that you're describing. It seems like there could be an issue with the way extensions are installed via the CLI vs the UI 🤔

cc @code-asher

Workaround

For now, the workaround is to install it while online via the UI

code-asher commented 2 years ago

Ah yeah I think it is the same issue here: https://github.com/coder/code-server/issues/3372#issuecomment-840859442

coder / code-server