coder / code-server

VS Code in the browser
https://coder.com
MIT License
67.58k stars 5.54k forks source link

[iPadOS] Can't copy/paste a whole line in editor #4766

Closed ManiaciaChao closed 2 years ago

ManiaciaChao commented 2 years ago

OS/Web Information

code-server: v4.0.1
VS Code: v1.63.0
Commit: 735c6da829535969ff7193c79379299e4a1cb9bc
Date: 2022-01-05T17:51:28Z (1 wk ago)
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.3 Safari/605.1.15
Remote OS: Debian 7 & Ubuntu 20.04 amd64

Steps to Reproduce

  1. Open an file.
  2. Copy/cut/paste a line from editor with shortcut cmd+c/x/v or from right-click menu.

Expected

It should apply on the whole line.

Actual

Nothing happens. Copy/cut/paste will only work for selected text, not the line.

Screenshot

https://user-images.githubusercontent.com/13493748/150166142-4f918300-6a4d-4199-85cf-d9b8eb08586c.mp4

Notes

This issue can be reproduced in VS Code: No

ManiaciaChao commented 2 years ago

Can be reproduced both in Safari and PWA.

dokastho commented 2 years ago

I had this issue in the same environment, removing the menu bar fixed it for me. View > Appearance > Show Menu Bar. I also have this bookmark added to my home screen

jsjoeio commented 2 years ago

Thanks @ManiaciaChao - can you try the workaround suggested by @dokastho?

Also can you reproduce this in vscode.dev?

ManiaciaChao commented 2 years ago

Thanks @ManiaciaChao - can you try the workaround suggested by @dokastho?

Also can you reproduce this in vscode.dev?

Unfortunately, that workaround doesn't work on my machine.

However, I found it an upstream issue with vscode or monaco-editor, which can be reproduced both on monaco-editor or vscode.dev.

Just close this issue for now :) I will open an issue at vscode's repo and try to make a PR in the next following days.

jsjoeio commented 2 years ago

@ManiaciaChao nice finds! Sounds good. Thank you so much for checking and following up :)