search

coder / code-server

VS Code in the browser
https://coder.com
MIT License
68.59k stars 5.62k forks source link

[Bug]: code-server 4.1.0 change github auth URL, breaking github copilot support. #4998

Closed yokowasis closed 2 years ago

yokowasis commented 2 years ago

Is there an existing issue for this?

OS/Web Information

Steps to Reproduce

  1. open code server
  2. install copilot
  3. auth with github

Expected

https://user-images.githubusercontent.com/1374064/159104514-87a2b51e-3096-4838-a393-f345d4310b1f.mp4

This is the video of code-server v4.0.2

Old auth url works fine by extracting the state, and put it into 

https://vscode-auth.github.com/authorize/?callbackUri=vscode://vscode.github-authentication/did-authenticate&scope=repo&state=${state}&responseType=code

as stated in #4363

Actual

New version of auth page comes up, github copilot can't find token, assuming I don't have access to github copilot.

Logs

No response

Screenshot/Video

https://user-images.githubusercontent.com/1374064/159104447-e7666ae7-24b3-4069-9912-1e81843dcd1d.mp4

Does this issue happen in VS Code?

Are you accessing code-server over HTTPS?

Notes

It looks like new version contain new url for authing with github. I would prefer to use old auth url (4.0.2) since it works fine with github copilot and others.

jsjoeio commented 2 years ago

I think due to licensing reasons, Copilot cannot be used with code-server. I can't find it on Open VSX.

Is there another extension that I can use to reproduce this?

yokowasis commented 2 years ago

I think due to licensing reasons, Copilot cannot be used with code-server. I can't find it on Open VSX.

Is there another extension that I can use to reproduce this?

Actually it can. And a lot of people including me can make it work, by installing the extension manually (on code-server v4.0.2). Refer to #4363. You can always download copilot from the microsoft marketplace and install it manually.

Can't we make an option for code-server to use old auth url instead of the new one ?

yokowasis commented 2 years ago

code-server 4.2.0 use a new kind of auth (8 alphanumeric). copilot can auth fine, with the new code-server 4.2.0.