coder / code-server

VS Code in the browser
https://coder.com
MIT License
67.29k stars 5.51k forks source link

[Fix]: Better output when installing with NPM #5537

Open edvincent opened 1 year ago

edvincent commented 1 year ago

Why do you want this feature?

In the postinstall.sh script that is used when installing with npm, we use nested commands to install vscode and its extensions - see code

As reported in https://github.com/coder/code-server/issues/5530 (and more in https://github.com/coder/code-server/pull/5533), installs were passing but actually failing - and only was seen during runtime.

The nested installs were failing, but the errors weren't being bubbled-up... Was only seen when using --foreground-scripts.

What is your suggestion?

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

Yes

jsjoeio commented 1 year ago

This seems like a nice UX improvement!