search

coder / code-server

VS Code in the browser
https://coder.com
MIT License
67.84k stars 5.57k forks source link

[Bug]: Tar Archives for releases contain broken symlinks #6139

Closed davellas closed 2 months ago

davellas commented 1 year ago

Is there an existing issue for this?

OS/Web Information

Not-relevant

Steps to Reproduce

  1. download any release e.g. code-server-4.11.0-linux-amd64.tar.gz
  2. folder /lib/vscode/extensions/node_modules/.bin contains broken links pointing to /lib/vscode/extensions/node_modules/typescript/bin that is not existing

Expected

The tar archives shouldn't contain broken symlinks as that can break certain archiving tools. Manually untarring the file will work, but not all similar tools will.

Actual

The tar archives contain broken symlinks resulting in errors when extracting the archive with certain tools

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

Are you accessing code-server over HTTPS?

Notes

No response

code-asher commented 1 year ago

Ah yeah for some reason VS Code leaves broken symlinks. We remove them before publishing the deb and rpm but not for the tars. We should move that line so it applies to all the release packages.

https://github.com/coder/code-server/blob/aed1fc0119b57e3141542c76285617ac88d1901e/ci/build/build-packages.sh#L56

code-asher commented 2 months ago

Duplicate of https://github.com/coder/code-server/issues/5157