coder / code-server

VS Code in the browser
https://coder.com
MIT License
67.27k stars 5.51k forks source link

[Feat]: Docker images based on other distributions #6661

Closed dsseng closed 6 months ago

dsseng commented 6 months ago

What is your suggestion?

Build more Docker/OCI images using various distributions.

Why do you want this feature?

Some peoples' workflows are accustomed to a certain distro, personally I like using Fedora for development. It provides more cutting edge build-dependencies and is preferred for me.

Are there any workarounds to get this functionality today?

I just build images myself using modified version of code-server Dockerfile also installing wanted extra dependencies. I believe the Dockerfile is MIT as well thus fine to modify as long as I keep the copy of the license along with it, sorry if I'm wrong.

Are you interested in submitting a PR for this?

Yes, I'd be happy to upstream my Dockerfile for Fedora-based code-server if developers approve this. Maybe I could do openSUSE Tumbleweed as well as I use it often as well.

code-asher commented 6 months ago

I believe the Dockerfile is MIT as well thus fine to modify as long as I keep the copy of the license along with it

Yup :+1:

Yes, I'd be happy to upstream my Dockerfile for Fedora-based code-server if developers approve this. Maybe I could do openSUSE Tumbleweed as well as I use it often as well.

Please feel free, this sounds good to me.

dsseng commented 6 months ago

Here's the latest version before I added more abstractions accomodating CLI editors and splitting base out: https://github.com/dsseng/fedora-development-containers/blob/baff02555eec68f70ec55a19867a859029e2a525/Dockerfile.code-server

This is quite a close reimplementation of the original Dockerfile. It uses GitHub releases and raw repo data to fetch rpm and container entrypoint respectively.

I'll submit a PR once this is considered decent option (also need to add CI stuff to generate those images). Also will try to do openSUSE Tumbleweed based one.

code-asher commented 6 months ago

That looks great!