coder / code-server

VS Code in the browser
https://coder.com
MIT License
67.89k stars 5.58k forks source link

[Bug]: No way to disable the VSCode custom title bar after updating #6718

Closed ading2210 closed 6 months ago

ading2210 commented 6 months ago

Is there an existing issue for this?

OS/Web Information

Steps to Reproduce

  1. Open code-server

Expected

There should be a way to disable the title bar, as it wastes vertical space that is already taken up by the browser's tab bar. In previous versions of code-server, the custom title bar was not shown by default.

Actual

There is no way to disable VSCode's built in title bar. Every solution mentioned here does not work.

The window.titleBarStyle setting does not exist in code-server, but in VSCodium, setting this to "native" disables the custom title bar.

Logs

No response

Screenshot/Video

Screenshot_2024-03-11_11-51-32

Does this issue happen in VS Code or GitHub Codespaces?

Are you accessing code-server over a secure context?

Notes

No response

code-asher commented 6 months ago

Huh so this seems to be a bug (or intentional change) upstream. Normally you can set the menu bar style to compact (the default) and disable the command center and the top bar will disappear, and this was working in 1.85.1, but in the latest VS Code it does not work. Codespaces is still on 1.85.2 so it does not reproduce there at the moment.

It can be reproduce with vscode.dev though.

code-asher commented 6 months ago

Wait no if you also disable the layout control in the titlebar then finally the top bar disappears. My settings:

{
    "window.commandCenter": false,
    "workbench.layoutControl.enabled": false
}
ading2210 commented 6 months ago

I just tried those settings and they worked, thanks! I guess the option names just changed between updates.