coder / code-server

VS Code in the browser
https://coder.com
MIT License
66.63k stars 5.46k forks source link

[Bug]: Unexpected behavior in extension settings #6724

Closed blotero closed 4 months ago

blotero commented 4 months ago

Is there an existing issue for this?

OS/Web Information

Steps to Reproduce

Hi, I'm currently working in the development team of a code extensions for our vulnerability scanning products: https://marketplace.visualstudio.com/items?itemName=FluidAttacks.fluidattacks

We are using code-server for developing end to end tests which run successfully in CI :rocket:.

However, I'm finding an incomplete disposal of settings from my extension in code-server.

These are the steps for setting up code-server with this extension and viewing the settings panel:

  1. Bundle the Fluid Attacks extension as shown here
  2. Execute code-server with the --install-extension flag including the bundled .vsix file.
  3. Open local host in the target port (9090 in my case)
  4. Go to Extensions > Fluid Attacks > Extension settings (@ext:fluidattacks.fluidattacks)

Expected

As described in the extensions package.json, there should be a configuration field called as Fluid Attacks: Api Token.

When executed in ms-vscode, this config field is indeed shown:

image

Actual

However, when viewing the configuration panel for this extension in code-server, this field is not shown:

image

Logs

 DONE  Packaged: /home/brandon/Projects/universe/integrates/retrieves/fluidattacks-0.64.1.vsix (26 files, 1.81MB)
[INFO] Packaged successfully
[2024-03-13T19:04:17.345Z] info  Wrote default config file to /tmp/tmp.j8qVkyUDII/.config/code-server/config.yaml
[2024-03-13T19:04:17.352Z] debug Found VS Code arguments; spawning VS Code CLI
[2024-03-13T19:04:17.353Z] debug Running Code CLI
Installing extensions...
Extension 'fluidattacks-0.63.0.vsix' was successfully installed.
/home/brandon/Projects/universe
/home/brandon/Projects/universe/integrates/retrieves /home/brandon/Projects/universe
[INFO] Starting code-server...
[2024-03-13T19:04:18.266Z] info  code-server 4.22.0 e5d145fdf32e82be2a0f8de9a3b05f65b13052b6
[2024-03-13T19:04:18.268Z] info  Using user-data-dir /tmp/tmp.j8qVkyUDII/.local/share/code-server
[2024-03-13T19:04:18.280Z] info  Using config file /tmp/tmp.j8qVkyUDII/.config/code-server/config.yaml
[2024-03-13T19:04:18.280Z] info  HTTP server listening on http://127.0.0.1:9090/
[2024-03-13T19:04:18.280Z] info    - Authentication is disabled
[2024-03-13T19:04:18.280Z] info    - Not serving HTTPS
[2024-03-13T19:04:18.280Z] info  Session server listening on /tmp/tmp.j8qVkyUDII/.local/share/code-server/code-server-ipc.sock

Screenshot/Video

The extension also behaves as expected in Github codespaces:

image

Does this issue happen in VS Code or GitHub Codespaces?

Are you accessing code-server over a secure context?

Notes

No response

blotero commented 4 months ago

We have addressed this issue internally. Closing.