search

coder / code-server

VS Code in the browser
https://coder.com
MIT License
66.51k stars 5.45k forks source link

Update Code to 1.88.1 #6754

Closed benz0li closed 2 months ago

benz0li commented 2 months ago

Ping @code-asher

benz0li commented 2 months ago

@code-asher Please re-run. My local build was successful.

code-asher commented 2 months ago

Weird, I ran it a couple times but it keeps getting ENOENT.

Oh...I think I know why. Something about node-gyp being removed from npm. We updated Node to 18.18.2, but it did not trigger a rebuild of VS Code because of the cache (~which itself is a bug I will have to fix~ actually this is fine because the built JavaScript is not dependent on the version of Node, it is only the release flows that matter and they do rebuild), so it is only now causing an issue.

Might work to install node-gyp globally, let me test it later today and see.

Edit: Although, not sure why the release flow worked and the build flow does not. They both use the same version of Node, and they both install @parcel/watcher.

benz0li commented 2 months ago

@code-asher What about the failed e2e tests?: https://github.com/coder/code-server/actions/runs/8698237868

code-asher commented 2 months ago

Ah yeah I was worried about that, looks like the Express update broke something.

Not to worry though, the commit that was actually released is https://github.com/coder/code-server/commit/9a28bc29dbddb6886dfe03dc1c31320249a901ce which did pass, that commit was just for updating the changelog and Helm chart afterward.

I will have to look into or revert the Express update though.

code-asher commented 2 months ago

Fixed!