coder / code-server

VS Code in the browser
https://coder.com
MIT License
66.47k stars 5.45k forks source link

Update Code to 1.90 #6822

Closed benz0li closed 4 weeks ago

benz0li commented 1 month ago

What is your suggestion?

Update Code to 1.90

Why do you want this feature?

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

benz0li commented 1 month ago

Expected release date: 06/05 (this may change)

https://github.com/microsoft/vscode/issues/213509

benz0li commented 1 month ago

@code-asher https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites has been updated:

benz0li commented 1 month ago

I will update package.json as follows

diff --git a/package.json b/package.json
index 1876caf3..9cde8469 100644
--- a/package.json
+++ b/package.json
@@ -44,7 +44,7 @@
     "@types/express": "^4.17.17",
     "@types/http-proxy": "1.17.7",
     "@types/js-yaml": "^4.0.6",
-    "@types/node": "^18.0.0",
+    "@types/node": "20.x",
     "@types/pem": "^1.14.1",
     "@types/proxy-from-env": "^1.0.1",
     "@types/safe-compare": "^1.1.0",
@@ -88,7 +88,7 @@
     "xdg-basedir": "^4.0.0"
   },
   "resolutions": {
-    "@types/node": "^18.0.0"
+    "@types/node": "20.x"
   },
   "bin": {
     "code-server": "out/node/entry.js"
@@ -103,7 +103,7 @@
     "remote-development"
   ],
   "engines": {
-    "node": "18"
+    "node": "20"
   },
   "jest": {
     "transform": {
code-asher commented 1 month ago

Perfect! Oh there is also a .node-version file we should update to match what they have in remote/.yarnrc.

benz0li commented 4 weeks ago

Perfect! Oh there is also a .node-version file we should update to match what they have in remote/.yarnrc.

diff --git a/.node-version b/.node-version
index 87ec8842..2dbbe00e 100644
--- a/.node-version
+++ b/.node-version
@@ -1 +1 @@
-18.18.2
+20.11.1
ByronHsu commented 4 weeks ago

Awesome! We badly need > 1.90.1 to be compatible with copilot chat extension from VSX.

benz0li commented 4 weeks ago

Code - OSS v1.90.0 was released yesterday: https://github.com/microsoft/vscode/releases/tag/1.90.0

I am in the process of creating a pull request.