search

coder / code-server

VS Code in the browser
https://coder.com
MIT License
66.47k stars 5.45k forks source link

Update Code to 1.90.0 #6824

Closed benz0li closed 4 weeks ago

benz0li commented 4 weeks ago

Fixes https://github.com/coder/code-server/issues/6822

benz0li commented 4 weeks ago

code-server-4.90.0-rc.1-linux-amd64.tar.gz with Code 1.90.0 is deployed at https://coder.jupyter.b-data.ch.

Functionality [modified by patches] tested and fond not to work:

Neither working in GUI nor Terminal. Output when executing e.g. code-server --install-extension alefragnani.project-manager

#8 11.48 Error while installing extensions: End of central directory record signature not found. Either not a zip file, or file is truncated.
#8 11.48 End of central directory record signature not found. Either not a zip file, or file is truncated.
#8 11.48 [2024-06-06T08:35:55.162Z] error parent:70 Uncaught exception: End of central directory record signature not found. Either not a zip file, or file is truncated.
#8 11.48 [2024-06-06T08:35:55.162Z] error parent:70 Error: End of central directory record signature not found. Either not a zip file, or file is truncated.
#8 11.48     at y (/opt/code-server/lib/vscode/out/vs/server/node/server.main.js:105:2374)
#8 11.48     at /opt/code-server/lib/vscode/out/vs/server/node/server.main.js:105:3812
#8 11.48     at /opt/code-server/lib/vscode/node_modules/yauzl/index.js:40:7
#8 11.48     at /opt/code-server/lib/vscode/node_modules/yauzl/index.js:190:5
#8 11.48     at /opt/code-server/lib/vscode/node_modules/yauzl/index.js:705:5
#8 11.48     at /opt/code-server/lib/vscode/node_modules/yauzl/fd-slicer.js:33:7
#8 11.48     at callback (/opt/code-server/lib/vscode/node_modules/graceful-fs/polyfills.js:138:21)
#8 11.48     at FSReqCallback.wrapper [as oncomplete] (node:fs:682:5)
benz0li commented 4 weeks ago

Functionality [modified by patches] tested and found to work:

Workspaces and Jupyter Notebooks also work fine:

ℹ️ Installing extensions from VSIX works.

benz0li commented 4 weeks ago

I followed the same procedure as with all previous release candidates. No idea what I might have missed.

@code-asher Please review.

code-asher commented 4 weeks ago

I think the marketplace error is related to the Microsoft.VisualStudio.Services.VsixSignature asset. From Microsoft's marketplace, this is a zip file, but from Open VSX it is not. I will do some more investigation, but maybe we will just have to disable signature verification.

code-asher commented 4 weeks ago

Ah yeah here is the issue https://github.com/eclipse/openvsx/issues/922

benz0li commented 3 weeks ago

I would like to confirm, that the marketplace is working fine with code-server v4.90.0-rc.1

Python extension, too: ms-python.python@2024.4.1

code-asher commented 3 weeks ago

Awesome thank you for confirming.

I am seeing a weird thing where the first web socket connection keeps timing out (seeing the handshake timed out in the browser console), making it appear like loading code-server takes a really long time. I am trying to figure out what it is, but I was curious to see if you were experiencing the same?

Edit: it works fine for me locally though. I tried to test on https://coder.jupyter.b-data.ch to see if maybe the problem was related to the way I was deploying it but it is timing out spawning at the moment.

benz0li commented 3 weeks ago

but it is timing out spawning at the moment.

Just try again. It will work eventually.

benz0li commented 3 weeks ago

but I was curious to see if you were experiencing the same?

No, I do not experience this on https://coder.jupyter.b-data.ch.

code-asher commented 3 weeks ago

Very weird, I tried clearing the CI cache to force a rebuild of VS Code and for some reason CI keeps dumping core, so I am trying 20.12.1 instead. It looks like VS Code uses the .nvmrc (20.12.1) to build, but then they ship the web version with the .yarnrc (20.11.1).

I have no idea why they use two different versions...I am going to just try building a new RC 20.12.1 and hopefully that works fine.

Edit: did not work, trying some things out here: https://github.com/coder/code-server/pull/6830

Edit: resolved a segfault in CI, but I still get the first timeout every time. Trying 20.12.1 again: https://github.com/coder/code-server/pull/6833

Edit: finally figured it out, putting out a patch release.

benz0li commented 3 weeks ago

but I was curious to see if you were experiencing the same?

No, I do not experience this on https://coder.jupyter.b-data.ch.

Did https://github.com/coder/code-server/commit/a73549539bb205169189158532c32d0fc44b104e resolve the web socket connection time outs?

ℹ️ In b-data's/my docker images --disable-telemetry is used when code-server is started.

code-asher commented 3 weeks ago

Did https://github.com/coder/code-server/commit/a73549539bb205169189158532c32d0fc44b104e resolve the web socket connection time outs?

It did, yup! In our environment for some reason os.cpus() is very slow (1-2 seconds), maybe because there are 64 cores? On my laptop it takes around 0.04 seconds. I think probably what happened is VS Code added new telemetry calls on startup, and those new calls caused enough delay due to the slow os.cpus() to trigger the timeout.

In b-data's/my docker images --disable-telemetry is used when code-server is started.

Ahhh that makes sense.