search

coder / code-server

VS Code in the browser
https://coder.com
MIT License
66.47k stars 5.45k forks source link

Update Node to 20.12.1 #6833

Closed code-asher closed 3 weeks ago

code-asher commented 3 weeks ago

Still trying to figure out a failure to connect the first time that reproduces consistently for me.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@0c802ba). Learn more about missing BASE report.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/coder/code-server/pull/6833/graphs/tree.svg?width=650&height=150&src=pr&token=5iM9farjnC&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder)](https://app.codecov.io/gh/coder/code-server/pull/6833?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder) ```diff @@ Coverage Diff @@ ## main #6833 +/- ## ======================================= Coverage ? 72.77% ======================================= Files ? 31 Lines ? 1899 Branches ? 410 ======================================= Hits ? 1382 Misses ? 437 Partials ? 80 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/coder/code-server/pull/6833?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/coder/code-server/pull/6833?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder). Last update [0c802ba...4e7def2](https://app.codecov.io/gh/coder/code-server/pull/6833?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=coder).
code-asher commented 3 weeks ago

I think I finally narrowed the issue down. Seems to have something to do with the display language patch. Experimenting with whether it can be removed or fixed, but this PR is not necessary.