search

coder / code-server

VS Code in the browser
https://coder.com
MIT License
66.47k stars 5.45k forks source link

Download of multiple files at once fails #6855

Open ldcorentin opened 1 week ago

ldcorentin commented 1 week ago

Is there an existing issue for this?

OS/Web Information

Steps to Reproduce

  1. Open coder-server in chrome
  2. Upload 20 files. (The total amount on my side is 76K)
  3. Download them all at once

Expected

I expect to have all 20 files in my download folder.

Actual

Sometimes I have 13, sometimes 15 files but never 20 files. No errors have been raised.

Logs

No response

Screenshot/Video

No response

Does this bug reproduce in native VS Code?

This cannot be tested in native VS Code

Does this bug reproduce in GitHub Codespaces?

I did not test GitHub Codespaces

Are you accessing code-server over a secure context?

Notes

No response

code-asher commented 1 week ago

Interesting. This code is all in VS Code so if we can reproduce in Codespaces we should try raising the issue upstream at https://github.com/microsoft/vscode.

ldcorentin commented 1 week ago

Thanks @code-asher, I just tried from Codespaces and I had no issues, I have all 20 files downloaded

code-asher commented 1 week ago

Very interesting! I have no idea what we could be doing differently.

I tried to reproduce with v4.90.3 on a remote server:

mkdir test-files
cd test-files
for i in {01..20}; do head -c 10K /dev/random > $i.txt; done

Then I selected them all, right clicked, download.

All 20 downloaded for me though. Could there be some network issues maybe? Do any warnings or errors show up in the browser log?

ldcorentin commented 1 week ago

I don't see any error logs in my browser. I've try to dig in our infrastructure but I don't see anything that is preventing me to do so :/

code-asher commented 1 week ago

Maybe there will be more logs if you run with --verbose but I am not sure.

Another thing you could try is running VS Code's web version directly without our code-server wrapper and patches (you can run it by installing VS Code and running code serve-web) and see if that exhibits the same behavior.