coder / code-server

VS Code in the browser
https://coder.com
MIT License
68.42k stars 5.61k forks source link

code server startup script is failing with error 'error Unexpected ( at 18, expected END: https://git.new/pathToRegexpError' #7002

Open mkc450 opened 1 month ago

mkc450 commented 1 month ago

Is there an existing issue for this?

OS/Web Information

Web Browser: Chrome Local OS: macOS Remote OS: Ubuntu Remote Architecture: amd64 code-server --version: 4.90.3

Steps to Reproduce

Start up command failed with the following error.

error Unexpected ( at 18, expected END: https://git.new/pathToRegexpError

We run npm audit fix --force before start up command to fix all vulnerable node packages.

Which upgraded version for path-to-regexp from 3.2.0 to 8.0.1 and its a breaking change for code-server with above mentioned error.

Below are the references which got upgraded. https://github.com/advisories/GHSA-9wv6-86v2-598j https://github.com/advisories/GHSA-qw6h-vgh9-j6wx

For now I downgraded the express to 4.21.0 and its dependency path-to-regexp@0.1.10 is used.

Expected

code server should be started, post upgrading vulnerable packages.

Actual

code server is not started

Logs

error Unexpected ( at 18, expected END: https://git.new/pathToRegexpError

Screenshot/Video

No response

Does this bug reproduce in native VS Code?

I did not test native VS Code

Does this bug reproduce in GitHub Codespaces?

I did not test GitHub Codespaces

Are you accessing code-server over a secure context?

Notes

No response

code-asher commented 1 month ago

I am not sure this is something we can fix? If I understand correctly, this is a dependency of Express so we have to wait until Express is updated.