coder / code-server

VS Code in the browser
https://coder.com
MIT License
67.82k stars 5.57k forks source link

iPad: Terminal input on chrome, iPad is hidden by keyboard #979

Closed partyka1 closed 2 years ago

partyka1 commented 5 years ago

Description

On safari there is no problem with that. Look at the screenshot, actually there 4-5 lines more there, that are hidden by keyboard

Steps to Reproduce

  1. Open new terminal
  2. Start typing
  3. After few lines you can't see what you type because input is hidden by system keyboard image
xlanor commented 5 years ago

Can reproduce this, using an ipad pro 12.9" with a logitech slim folio pro.

Code-server deployed using code-server:2.1472-vsc1.38.1 docker image from dockerhub on Ubuntu 18.04 bionic.

However, I also observed this issue in v1 before I switched to v2.

Doesn't occur in safari (in safari it is pushed up nicely), but in safari, none of the top tabs work properly, they flicker on click.

xlanor commented 5 years ago

Here’s some screenshots to better demonstrate the layout in safari vs the layout currently getting in chrome

Safari: IMG_0137

Chrome: IMG_0136

sr229 commented 5 years ago

@partyka1 give v2 a try. v1 is already a deprecated version and we won't be issuing fixes in v1.

xlanor commented 5 years ago

@sr229 , this issue is still prevalent in image code-server:2.1472-vsc1.38.1 from dockerhub.

sr229 commented 5 years ago

Thanks for the report @xlanor. Will raise this to the team.

partyka1 commented 5 years ago

@sr229 dev team should look at zeplin.io, im using their site on iPad and they have fixed elements on bottom of the screen that correctly react to keyboard ui situation that happens on iPad. Im sure vs code layout is another level of complexity, but if they are planning to address the issue this might help

partyka1 commented 5 years ago

I've found ohmazing workaround the problem, click View > Appearance > Move Side Bar Right then split the terminal view horizontally and rescale the bottom window so it offsets the top by the keyboard ui height @xlanor 5AD1C38C-E6D6-4D51-8B72-60C9FBA69A56

xlanor commented 5 years ago

Thanks! I guess thats an alternative, although it would be much preferable since I dont use my terminal that much - which is why the blocking affects me more.

ttfan240 commented 4 years ago

If you disable "Shortcuts" in the iPad settings app, the keyboard screen itself will not appear. Settings > General > Keyboard > Shortcuts I didn't use the feature in the first place, so this is enough for me. I use iPad in Japanese, so it may not be helpful.

nhooyr commented 4 years ago

@cmoog please test!

jsjoeio commented 3 years ago

I’ve been using code-server on iPad as well. @ttfan240 issue resolved it for me.

@partyka1 will that solution work for you and can we close this?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

kmilov commented 2 years ago

Indeed disabling Shortcuts and Predictive in Settings -> General -> Keyboard , on the iPad (pro M1) stops showing the bar in Code Server, with the disadvantage that the bar will be disabled everywhere.

is there an option to disabled it itself in the PWA Code Server ?

jsjoeio commented 2 years ago

@kmilov I don't think so :/ at least I'm not aware of any abilities to make those settings for specific PWAs.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

YoungjuneKwon commented 9 months ago

Anybody knows the solution for this problem? I think this issue is still going, though it has been closed by stable bot. So I think the issue should be reopened.

code-asher commented 9 months ago

Not sure about workarounds, but here is the upstream issue, feel free to give it a thumbs up: https://github.com/microsoft/vscode/issues/149048