search

coder / coder

Provision remote development environments via Terraform
https://coder.com
GNU Affero General Public License v3.0
7.35k stars 595 forks source link

chore: implement default pagination limit #13673

Closed Emyrk closed 2 days ago

Emyrk commented 2 days ago

Specifying no limit should return a default of >0. I noticed this for audit logs. Tests had to specify a limit >0.

johnstcn commented 2 days ago

Is this causing an issue? Looking through the history of this file, it was explicitly set to -1 to return all results.

Emyrk commented 2 days ago

Is this causing an issue? Looking through the history of this file, it was explicitly set to -1 to return all results.

Oh I see. The change was here: https://github.com/coder/coder/pull/2663

I will update the audit logs query to interpret 0 as all then. :+1: Good catch