search

coder / envbuilder

Build development environments from a Dockerfile on Docker, Kubernetes, and OpenShift. Enable developers to modify their development environment quickly.
Apache License 2.0
154 stars 28 forks source link

chore: warn if docker secret cleanup fails #163

Closed BrunoQuaresma closed 6 months ago

BrunoQuaresma commented 6 months ago

Closes https://github.com/coder/envbuilder/issues/159

johnstcn commented 6 months ago

I think this might also be a good place to add a check in the integration tests that the docker config.json was removed, something like this might work:

        statOutput := execContainer(t, ctr, "stat "+filepath.Join(envbuilder.MagicDir, "config.json"))
        require.Contains(t, statOutput, "No such file or directory")